fix: disable View as Chart/Table for non-thematic maps #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1997--dhis2-dashboard.netlify.app |
edoardo
approved these changes
Sep 28, 2021
dhis2-bot
added a commit
that referenced
this pull request
Sep 28, 2021
## [31.19.13](v31.19.12...v31.19.13) (2021-09-28) ### Bug Fixes * disable View as Chart/Table for non-thematic maps ([#1997](#1997)) ([cc1a44d](cc1a44d))
|
🎉 This PR is included in version 31.19.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Sep 28, 2021
Fixes https://jira.dhis2.org/browse/DHIS2-11889 Fixes in this PR * Open in [appName] app should be enabled even when offline * When online, View as options for non-thematic maps should be disabled with tooltip "This map not available as a Chart" * Dimension filter settings confirm button should not have an offline tooltip, because clicking the "Confirm" button doesn't trigger an api request * Print button in More menu should be enabled for cached dashboards when offline
jenniferarnesen
added a commit
that referenced
this pull request
Sep 28, 2021
Fixes https://jira.dhis2.org/browse/DHIS2-11889 Fixes in this PR * Open in [appName] app should be enabled even when offline * When online, View as options for non-thematic maps should be disabled with tooltip "This map not available as a Chart" * Dimension filter settings confirm button should not have an offline tooltip, because clicking the "Confirm" button doesn't trigger an api request * Print button in More menu should be enabled for cached dashboards when offline
jenniferarnesen
added a commit
that referenced
this pull request
Oct 1, 2021
Fixes https://jira.dhis2.org/browse/DHIS2-11889 Fixes in this PR * Open in [appName] app should be enabled even when offline * When online, View as options for non-thematic maps should be disabled with tooltip "This map not available as a Chart" * Dimension filter settings confirm button should not have an offline tooltip, because clicking the "Confirm" button doesn't trigger an api request * Print button in More menu should be enabled for cached dashboards when offline
jenniferarnesen
added a commit
that referenced
this pull request
Oct 1, 2021
#2006) Fixes https://jira.dhis2.org/browse/DHIS2-11889 Fixes in this PR * Open in [appName] app should be enabled even when offline * When online, View as options for non-thematic maps should be disabled with tooltip "This map not available as a Chart" * Dimension filter settings confirm button should not have an offline tooltip, because clicking the "Confirm" button doesn't trigger an api request * Print button in More menu should be enabled for cached dashboards when offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.dhis2.org/browse/DHIS2-11889
Fixes in this PR
Online, non-thematic map on the left:
134941560-2392c30d-e772-4b8a-b48e-fa006b58ab79.mov
Offline - Open in Maps app should be enabled
134941580-70551964-9329-41b1-aced-49af35fd4b3b.mov
Offline, non-thematic map - message should be "Not available offline"
134941591-a9a4364b-fd64-4918-ba85-f868133f2af9.mov