Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: applying a filter to a dashboard with a Map item results in the map not rendering [DHIS2-11054] #1741

Merged
merged 20 commits into from
May 31, 2021
Merged

fix: applying a filter to a dashboard with a Map item results in the map not rendering [DHIS2-11054] #1741

merged 20 commits into from
May 31, 2021

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented May 4, 2021 •
edited
Loading

After switching to dynamically loaded plugins, the MapPlugin's "unmount" call became asynchronous. The end result is that the map was unmounted after being re-rendered with the applied filter.

The fix is to not unmount the map when switching item filter, as this is not necessary.

Some other related improvements were made:

  • move the "filter version" handling out of Item and into Visualization, which is closer to where it is actually used.
  • DefaultPlugin (base component for Maps, EV and ER) now checks the filterVersion as well when determining whether reload is necessary
  • MapPlugin component is responsible for it's unmounting (EV and ER do not have an unmount function)

@jenniferarnesen jenniferarnesen changed the title fix: do not unmount map when changing filter, just load the new config fix: Map View as Chart or Table does not render the chart or table [DHIS2-11054] May 4, 2021
@jenniferarnesen jenniferarnesen changed the title fix: Map View as Chart or Table does not render the chart or table [DHIS2-11054] fix: applying a filter to a dashboard with a Map item results in the map not rendering [DHIS2-11054] May 4, 2021
@jenniferarnesen jenniferarnesen merged commit cd4d2d6 into master May 31, 2021
@jenniferarnesen jenniferarnesen deleted the fix/map-not-rerendering-with-filters branch May 31, 2021 11:38
dhis2-bot added a commit that referenced this pull request May 31, 2021
@dhis2-bot
chore(release): cut 31.16.0 [skip ci]
9cac9f9 
# [31.16.0](v31.15.6...v31.16.0) (2021-05-31)

### Bug Fixes

* applying a filter to a dashboard with a Map item results in the map not rendering [DHIS2-11054] ([#1741](#1741)) ([cd4d2d6](cd4d2d6))

### Features

* hide periods based on system settings (DHIS2-11161) ([#1789](#1789)) ([d01c2e6](d01c2e6))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoardo edoardo edoardo approved these changes

@turban turban Awaiting requested review from turban

@janhenrikoverland janhenrikoverland Awaiting requested review from janhenrikoverland

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenniferarnesen @dhis2-bot @edoardo