feat: add confirmation dialog for discarding changes to dashboard #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooper-joe
approved these changes
Apr 22, 2021
edoardo
approved these changes
Apr 23, 2021
…oard-app into feat/discard-changes-confirm
dhis2-bot
added a commit
that referenced
this pull request
Apr 27, 2021
# [31.15.0](v31.14.11...v31.15.0) (2021-04-27) ### Bug Fixes * make New button icon-only and set redirect url rather than use Link component ([#1714](#1714)) ([686d970](686d970)) * namespace check issue ([#1725](#1725)) ([0997714](0997714)) ### Features * add confirmation dialog for discarding changes to dashboard ([#1713](#1713)) ([0fd4d1c](0fd4d1c))
|
🎉 This PR is included in version 31.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was requested as part of the Dashboard PWA [DHIS2-10874]. (when editing a dashboard and connectivity lost, then the dialog can be used to warn user of lost changes if they exit).
If a user makes any change (name, description, changes to items or filter settings), then the dirty state will be set and the dialog will be triggered when exiting without saving. However, adding translations does not affect the dirty status of the dashboard.