fix: use window height to determine expanded control bar height on small screens #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Mar 9, 2021
| @@ -12,6 +12,9 @@ | |||
| --user-rows-height: calc( | |||
| var(--controlbar-padding) + (var(--user-rows-count) * var(--row-height)) | |||
| ); | |||
| --sm-expanded-controlbar-height: calc( | |||
| (var(--vh, 1vh) * 100) - var(--headerbar-height) - 32px | |||
dhis2-bot
added a commit
that referenced
this pull request
Mar 9, 2021
## [31.13.7](v31.13.6...v31.13.7) (2021-03-09) ### Bug Fixes * add scatter icon for ItemSelector ([#1614](#1614)) ([66ac287](66ac287)) * calc fullscreen height of visualization based on window height ([#1621](#1621)) ([13c79b9](13c79b9)) * preserve sharing and translations when saving dashboard ([#1611](#1611)) ([802405d](802405d)), closes [dhis2/dhis2-core#7538](dhis2/dhis2-core#7538) * use window height to determine controlbar height ([#1620](#1620)) ([d7d730f](d7d730f))
|
🎉 This PR is included in version 31.13.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully fix the issue where the expanded control bar on the phone is too tall. Using window height should take into account the phone's available screen space considering address bar and navigation controls on some phone models.