feat: Restricting view options of dashboard items (DHIS2-7630) #1472
Conversation
benguaraldi
changed the title
benguaraldi
changed the title
|
@benguaraldi I'll be looking at this Thur or Fri this week :) |
|
@jenniferarnesen Great, thanks! |
conditions ItemHeaderButtons display based on system settings
|
|
||
| const { baseUrl } = useConfig() | ||
|
|
||
| const { item, visualization, onSelectActiveType, activeType } = props | ||
|
|
||
| const { settings } = useSystemSettings() | ||
| const { |
There was a problem hiding this comment.
What about doing this renaming at the point of the response, so it will be consistent throughout the app? It would probably be done in SystemSettingsProvider. (And then update the names throughout the app where systemSettings is used)
There was a problem hiding this comment.
Sounds good. I've refactored and put the logic for the remappings in api/settings (applied in SystemSettingsProvider). Let me know if this is okay, or if you'd like me to implement some other way
tomzemp@bf04217
# [31.11.0](v31.10.9...v31.11.0) (2021-02-15) ### Features * Restricting view options of dashboard items (DHIS2-7630) ([#1472](#1472)) ([e74ee29](e74ee29))
|
🎉 This PR is included in version 31.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks, @jenniferarnesen and @tomzemp! |
This pull request implements PEFPAR's suggestion for restricting view options from within dashboard items (https://jira.dhis2.org/browse/DHIS2-7630) using newly added system settings.