-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: responsive item grid in view and edit mode [DHIS2-10138] #1431
Merged
jenniferarnesen
merged 50 commits into
master
from
feat/responsive-view-for-small-screens
Jan 29, 2021
Merged
feat: responsive item grid in view and edit mode [DHIS2-10138] #1431
jenniferarnesen
merged 50 commits into
master
from
feat/responsive-view-for-small-screens
Jan 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
Feat/responsive view for small screens
feat: responsive item grid
Jan 6, 2021
# Conflicts: # src/AppWrapper.js
This reverts commit 65ac1f4.
jenniferarnesen
changed the title
feat: responsive item grid
feat: responsive item grid in view and edit mode [DHIS2-10138]
Jan 27, 2021
edoardo
approved these changes
Jan 29, 2021
dhis2-bot
added a commit
that referenced
this pull request
Jan 29, 2021
# [31.10.0](v31.9.0...v31.10.0) (2021-01-29) ### Features * responsive item grid in view and edit mode [DHIS2-10138] ([#1431](#1431)) ([0e0c93f](0e0c93f))
🎉 This PR is included in version 31.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the responsive dashboard grid in View and Edit mode.
Refactoring:
gridUtil
to modules folder (and move some functions into separate modules (smallScreen, getGridItemDomId) to reduce scope of gridUtil)** these functions in gridUtil haven't changed:
getPrintTitlePageItemShape
,getPageBreakItemShape
,hasShape
,withShape
,getShape
,isNonNegativeInteger
ViewItemGrid
andEditItemGrid
components (used to be ItemGrid with editMode flag) since functionality and grid props very differentwindowHeight
redux prop with theuseWindowDimensions
hookPrintItemGrid
andPrintLayoutItemGrid
by breaking out aStaticGrid
component with the common functionality