fix(cli-43): skip git ops when not a git repo #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a gitEnabled() function used to identify if Git operations like linting commits and installing hooks should be done. Modifies how the PROJECT_ROOT is identified when there is no .git directory by adding additional root-level files like yarn.lock and package.json. May be a risk for false positives in a monorepo, will need to monitor that a bit. Jira-Issue: CLI-43
The yarn.lock should only exist at the root level even in workspaces, and if someone is using NPM the same should be true for the package-lock.json. The .d2 directory is not a good indicator of the project root, so removing that from the checks.
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a gitEnabled() function used to identify if Git operations
like linting commits and installing hooks should be done.
Modifies how the PROJECT_ROOT is identified when there is no .git
directory by adding additional root-level files like yarn.lock and
package-lock.json.
Jira-Issue: CLI-43