fix: allow ignore files to be read (#100)

* fix: allow ignore files to be read * fix: skip general messages reported without line numbers
dhis2 · Jul 17, 2019 · a89faab · a89faab
1 parent 21d323c
commit a89faab
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/tools/js/eslint.js b/src/tools/js/eslint.js
@@ -28,7 +28,8 @@ module.exports = (file, text, apply = false) => {
     const options = {
         baseConfig: require(eslintConfig),
         fix: apply,
-        ignore: false,
+        ignore: true,
+        reportUnusedDisableDirectives: true,
     }
     try {
         const engine = new eslint.CLIEngine({
@@ -72,10 +73,16 @@ module.exports = (file, text, apply = false) => {
             if (message.ruleId) {
                 rule = `(${message.ruleId})`
             }
-            response.messages.push({
-                checker: 'eslint',
-                message: `Line ${message.line}: ${message.message} ${rule}`,
-            })
+            if (message.line) {
+                response.messages.push({
+                    checker: 'eslint',
+                    message: `Line ${message.line}: ${message.message} ${rule}`,
+                })
+            } else {
+                log.debug(
+                    `No line number, assuming general message: ${message.message}`
+                )
+            }
         }
     } catch (error) {
         log.error(`ESLint format failed with error:\n${error}`)