feat: add offline service #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
reviewed
Jun 14, 2021
mediremi
reviewed
Jun 14, 2021
mediremi
reviewed
Jun 14, 2021
mediremi
approved these changes
Jun 29, 2021
KaiVandivier
commented
Jun 29, 2021
services/offline/README.md
Outdated
|
|
||
| ## Installation | ||
|
|
||
| This package is internal to `@dhis2/app-runtime` and generally should not be installed independently. |
There was a problem hiding this comment.
(This is not true yet - will be true once released and reexported from the app-runtime package)
KaiVandivier
commented
Jun 29, 2021
services/offline/jest.config.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
This file is copied/pasted from other services packages
KaiVandivier
commented
Jun 29, 2021
| @@ -0,0 +1,22 @@ | |||
| import { render } from '@testing-library/react' | |||
There was a problem hiding this comment.
This is a bit of a placeholder; currently just the offlineInterface initialization is tested. More to come in the future
amcgee
reviewed
Jul 21, 2021
services/offline/src/index.js
Outdated
Comment on lines
1
to
3
| export { OfflineProvider } from './lib/offline-provider' | ||
| export { CacheableSection, useCacheableSection } from './lib/cacheable-section' | ||
| export { useOnlineStatus } from './lib/online-status' |
There was a problem hiding this comment.
I think this is OK for now, we can add an export of useCachedSections in the future if we need it
amcgee
reviewed
Jul 21, 2021
| import React from 'react' | ||
|
|
||
| // eslint-disable-next-line react/prop-types | ||
| export const RenderCounter = ({ id, countsObj }) => { |
There was a problem hiding this comment.
Yeah that's right
Co-authored-by: Austin McGee <947888+amcgee@users.noreply.github.com>
…pp-runtime into feat-add-offline-service
* chore: add tsconfig and set up package.json * refactor: convert online-status to TS * refactor: convert index and setupRTL to TS * chore: switch entry point to index.ts * refactor: add types to offline-provider * refactor: move shared types to own file * refactor: add types to offline interface * refactor: add types to global state service * chore: update path to RTL setup * refactor: add types to cacheable section * refactor: recording state type * refactor: make sure offlineInterface is never null * refactor: global state mutation types * refactor: add types to cacheable section state * refactor: offline provider return value * refactor(offline-provider): make children optional * refactor: offline-provider test to typescript * refactor: make options optional * refactor: convert to typescript * refactor: convert to typescript * refactor: convert to typescript * refactor: convert to typescript * refactor: use stricter TS settings * chore: specify milliseconds in debounceDelay type
…ction (#946) * fix: allow useCS hook to be used in child of CS component * refactor: also remove recording state on unmount if 'error' * refactor: make conditions clearer
1 task
dhis2-bot
added a commit
that referenced
this pull request
Aug 31, 2021
# [2.11.0](v2.10.0...v2.11.0) (2021-08-31) ### Features * add offline service ([#874](#874)) ([578bd41](578bd41))
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
<OfflineProvider>component that serves a<CacheableSection>component, auseCacheableSectionhook, anduseCachedSection(s)hook(s) as a part of Dashboard as a Progressive Web App. Also include auseOnlineStatushook.To do after alpha release:
offline-servicemodules fromruntimepackage