Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support multiple of same query string for LambdaProxyIntegrationEventV2 #1525

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

drace-rgare
Copy link
Contributor

@drace-rgare drace-rgare commented Aug 4, 2022

Description

Instead of using multiValueQueryStringParameters API Gateway HTTP API combines duplicate query string keys with commas in the queryStringParameters field.

Motivation and Context

Issue #1437
Similar change to PR #1438 but woodybriggs never added the tests for it, and wasn't returning null for empty search params, one of the test scenarios.

Before this change:

http://example.com/endpoint?filter=1&filter=2
Would be serialized as

{
    "filter": 2
}

After this change

{
    "filter": "1,2"
}

https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

How Has This Been Tested?

New unit tests added, based off of scenarios from parseMultiValueQueryStringParameters tests

Screenshots (if appropriate):

@dnalborczyk dnalborczyk changed the title Support multiple of same query string for LambdaProxyIntegrationEventV2 fix: Support multiple of same query string for LambdaProxyIntegrationEventV2 Sep 5, 2022
@dnalborczyk dnalborczyk merged commit 7416c1c into dherault:master Sep 5, 2022
@dnalborczyk
Copy link
Collaborator

thank you @drace-rgare !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants