fix: event.resource in catch-all route gets + changed to * #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnalborczyk
requested changes
Aug 4, 2022
| @@ -146,7 +146,11 @@ export default class LambdaProxyIntegrationEvent { | |||
| const httpMethod = method.toUpperCase() | |||
| const requestTime = formatToClfTime(received) | |||
| const requestTimeEpoch = received | |||
| const resource = this.#routeKey || route.path.replace(`/${this.#stage}`, '') | |||
| // const resource = this.#routeKey || route.path.replace(`/${this.#stage}`, '') | |||
| // NOTE Removed * added by generateHapiPath so api gateway event is accurategenerateHapiPath | |||
There was a problem hiding this comment.
// NOTE Removed Replaced...?
what is accurategenerateHapiPath?
|
thank you @Ankcorn ! added some comments, otherwise looks good.
|
dnalborczyk
changed the title
|
woops a few typo's here, serves me right for making PR's at midnight. I have fixed those up, thanks for checking the http api :) |
happens to me fairly often as well 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the * added by the generateHapiPath util for rest apis as this does not match the events from AWS
Motivation and Context
I ran into this bug event.resource in catch-all route gets + changed to * whilst testing out some changes to TRPC and their lambda adaptor.
How Has This Been Tested?
I added a new e2e test to cover the described behavior and it asserts that the resource contains the + character as expected
Screenshots (if appropriate):
N/A
fixes: #1431