Support httpApi payload override on handler #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
reviewed
Dec 2, 2021
src/ServerlessOffline.js
Outdated
| ? service.provider.httpApi.payload | ||
| : '2.0' | ||
| if (functionDefinition.httpApi && functionDefinition.httpApi.payload) { | ||
| httpEvent.http.payload = functionDefinition.httpApi.payload; |
There was a problem hiding this comment.
I believe in that case eventual setting on httpEvent should take precedence
There was a problem hiding this comment.
httpEvent? Do you mean the provider setting? If so, isn't that counterintuitive?
There was a problem hiding this comment.
Sorry, ignore my comment. There's no setting on event directly (it obviously wouldn't make sense :)
medikoo
approved these changes
Dec 2, 2021
src/ServerlessOffline.js
Outdated
| ? service.provider.httpApi.payload | ||
| : '2.0' | ||
| if (functionDefinition.httpApi && functionDefinition.httpApi.payload) { | ||
| httpEvent.http.payload = functionDefinition.httpApi.payload; |
There was a problem hiding this comment.
Sorry, ignore my comment. There's no setting on event directly (it obviously wouldn't make sense :)
|
Fixed. I imagine there may be some other overrides currently being overlooked like this. I'll send in a PR if I come across any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for getting the payload version for
httpApifunctions from the function definition (ie overriding theproviderlevel).Motivation and Context
According to the serverless docs, you can specify
httpApi.payloadat either the service or function level. However, serverless-offline was ignoring the value set at the function level. This PR fixes that.How Has This Been Tested?
I've tested this in my current project.