fix: lowercase API gateway V2 event headers #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the [AWS documentation](https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html), header names are lowercased before being passed to the function. This change ensures serverless-offline accurately reflects the header handling done by AWS Lambda.
|
Hi @pgrzesik, are you able to review this please? |
|
thank you @domdomegg ! |
|
Thanks for merging this @dnalborczyk :) |
domdomegg
added a commit
to raisenational/raise
that referenced
this pull request
May 17, 2022
domdomegg
added a commit
to raisenational/raise
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the AWS documentation, header names are lowercased before being passed to the function for API Gateway HTTP API events (known in serverless as
httpApi). This change ensures serverless-offline accurately reflects the header handling done by AWS Lambda.NB: this does not update the behaviour of API Gateway REST API events, where serverless-offline does not change the header capitalization to match Amazon.
Motivation and Context
Fixes #1207
How Has This Been Tested?
Tested it on my own service, and appears to work well.
Added unit tests for lowerCaseKeys helper function.
Added integration test for header lowercasing.