-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Use same diff format in notification and in diff page. #2554
Comments
Hmm it's not a bug, more a "feature", because they use different ways to present the data the coloured version is actually rendered by JavaScript which CANNOT be used in emails, discord, slack etc |
Yes I understand, so maybe the issue I have is more the "diff notification is complex whereas it seems it could be not"? Diff in notification:
As you can see, there are just some lines removed but the diff algorithm thought it was way more than that :P |
Describe the bug
Often I see that the diff in the notification is different than on the diff page. Sometimes there is a tiny change (like one red line and one green line) on the diff page but the notification diff is enormous (tens of lines of changed, into, added, removed).
Version
Exact version in the top right area: 0.46.02
Expected behavior
I expect the diff to be the same
Screenshots
Here is a small example where the lines "removed" are not the same in notification and in diff page
notification
diff page
The text was updated successfully, but these errors were encountered: