Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add a confirmation pop up when pressing Clear #66

Closed
Michpem opened this issue Apr 17, 2024 · 2 comments
Closed

[Request] Add a confirmation pop up when pressing Clear #66

Michpem opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request fixed This issue was fixed, waiting for stable release

Comments

@Michpem
Copy link

Michpem commented Apr 17, 2024

Hello! I have a small feature suggestion. Would it be possible to add a small pop up window asking for confirmation when the Clear button is pressed? I accidentally clicked on it the other day and wiped out my SPC playlist, haha. Thankfully, I had a backup .lst file so nothing was lost, but having a confirmation dialog in case accidents like these happen would be nice. Perhaps something like this:

"Are you sure you want to clear your playlist? This action cannot be reversed.
[Yes] [Cancel]"

This is a very small request, so feel free to prioritize any potential updates you may have planned instead of this!

@dgrfactory
Copy link
Owner

Hi, @Michpem

Thank you for reporting the new request.
And, I am sorry to trouble you.

In the following releases, a confirmation dialog has been added when clearing a playlist.
I used the sample message you sent as is, thanks!
https://github.com/dgrfactory/spcplay/releases/tag/2.20.3.8412b

@dgrfactory dgrfactory self-assigned this Apr 17, 2024
@dgrfactory dgrfactory added enhancement New feature or request fixed This issue was fixed, waiting for stable release labels Apr 17, 2024
@Michpem
Copy link
Author

Michpem commented Apr 17, 2024

No trouble at all! And thank you very much for adding this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed This issue was fixed, waiting for stable release
Projects
None yet
Development

No branches or pull requests

2 participants