Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update magic number of Badger just before v1.0 release #282

Closed
deepakjois opened this issue Oct 23, 2017 · 5 comments
Closed

Update magic number of Badger just before v1.0 release #282

deepakjois opened this issue Oct 23, 2017 · 5 comments
Milestone
v1.0

Comments

@deepakjois
Copy link
Contributor

deepakjois commented Oct 23, 2017 •
edited
Loading

This would probably mean anybody who is using Badger prior to v1.0 will have to re-import their data (include Dgraph users).
@deepakjois deepakjois added this to the v1.0 milestone Oct 23, 2017
@manishrjain
Copy link
Contributor

Just confirm with IPFS folks that it would help.

@deepakjois
Copy link
Contributor Author

cc: ipfs/kubo#4327

@deepakjois
Copy link
Contributor Author

Maybe we should do this anyway, just to start off with a clean slate. Just need to make sure that we have covered all the implications of changing the magic number for existing data.

@manishrjain
Copy link
Contributor

I'd like to avoid adding more things in the run towards v1.0. Unless IPFS folks see a clear benefit, we can release v1.0 and then work towards a solution to upgrade Badger data on disk.

@deepakjois deepakjois mentioned this issue Oct 24, 2017
Merged
deepakjois added a commit that referenced this issue Oct 25, 2017
@deepakjois
Update magic number from 2 to 3.
24f122a 
Fixes #282.
@deepakjois deepakjois mentioned this issue Oct 25, 2017
Closed
@deepakjois
Copy link
Contributor Author

Moving #135 to v1.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@deepakjois @manishrjain