Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to customize the system account name using a config named common-chain-system-account #211

Open
cppfuns opened this issue Jan 31, 2021 · 1 comment

Comments

@cppfuns
Copy link

cppfuns commented Jan 31, 2021

I currently customize development based on EOSIO-eos. Compared with EOSIO-eos, the difference is the prefixes of custom genesis account and system account.

I would like to ask whether dfuse-eosio supports parameterized setting of genesis account and system account prefix? For eosio-eos doing baas, modifying the prefix of the genesis account and system account is also the most basic support.
For the existing settings, the default value can also be the current parameters of eosio-eos, and there will be no other impact

@maoueh
Copy link
Contributor

maoueh commented Feb 2, 2021

Indeed, we have eosio hard-coded at some places throughout the code. We are open for a PR that implement the feature of making the system account configurable, it’s something good for the product, just not a priority for us.

All chains we ever need to support so far still used the eosio system account in some ways. It never been a problem for us for far. Note that the ecosystem itself is not sometimes well supporting other system account name.

Turning this into a feature request and updating the title.

@maoueh maoueh changed the title dfuse-eosio supports custom genesis account and system account prefix Add support to customize the system account name using a config named common-chain-system-account Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants