Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project enhancements proposal to support current version of Edge.Js #8

Open
agracio opened this issue Apr 15, 2024 · 9 comments
Open

Comments

@agracio
Copy link

agracio commented Apr 15, 2024

Hi,
I maintain an up-to-date version of Edge.Js https://github.com/agracio/edge-js that supports modern versions of Node.Js, modern .Net Core versions, incorporates unmerged PRs from original Edge.Js repo and receives constant updates via new PRs and code improvements.

Currently I am looking at migrating various language integrations like edge-ps and others to support .NET core.
I have already created an alternative package that uses dotnet 8 to handle PowerShell https://github.com/agracio/edge-ps-core the only difference is that it requires to have ps-core as language specification vs ps.

Was wondering if you would be open to the idea of transferring the project to me so I could maintain both .NET Framework and Core versions in one package while adding any necessary improvements.

@dfinke
Copy link
Owner

dfinke commented Apr 15, 2024

Wow, cool. Sure, let me know how to transfer. Would appreciate if you cite me as the orginal creator of the PS version.

@agracio
Copy link
Author

agracio commented Apr 15, 2024

I think in NPM under https://www.npmjs.com/package/edge-ps 'Settings' tab you could add me (agracio) as maintainer so that would allow me to publish package as edge-ps instead of using a different package name.
In GitHUb I could just maintain a fork it would make things easier.

As for citation I do not want to take credit for someone else's hard work, it will be at the top of the README.
Will put a big logo if you have one 😃

@dfinke
Copy link
Owner

dfinke commented Apr 16, 2024

Thanks for thinking about maintaining this! I'm not comfortable adding a maintainer to npm. Its not that I don't trust you. I don't trust anyone. 🙂

Packages that have my name on it, I need to keep close.

Feel free to publish it on npm with a different name. Be great if you could give me some credit if not. No worrries.

@agracio
Copy link
Author

agracio commented Apr 16, 2024

There is a way to completely transfer NPM package ownership: https://docs.npmjs.com/transferring-a-package-from-a-user-account-to-another-user-account.

But if you are not comfortable with that I will just keep your edge-ps package referenced in docs for anyone who uses .NET 4.5 and will maintain https://github.com/agracio/edge-ps-core for dotnet 8.

Readme states that it is a fork of your project to support .NET Core however I omitted most your screenshots and description as I did not transfer any of the supporting try functionality to the new package .

EDIT: Btw I completely understand the point of not wanting to add a random maintainer to your own package

@agracio
Copy link
Author

agracio commented Apr 16, 2024

I had a quick chat with tjanczuk (no @ as there is no reason to ping him) and he was happy to agree to add me as maintainer to both his GitHub projects and NPM. Hope it makes you feel more at ease.

@dfinke
Copy link
Owner

dfinke commented Apr 17, 2024

Cool. I dm'd Tomasz on X. Last time I dm'd him was 11 years ago 😆. I vaguely remember him posting back then when he stepped away you were taking up the reins.

I need to see if I need to change my pwd on npm. I've gotta bunch of things I need to square away. May take a few days till I let you know when I've added you. - Thanks

@agracio
Copy link
Author

agracio commented Apr 17, 2024

I spoke to him on Slack (same username), not sure about his Twitter activity. But sure thing take your time I completely understand.

@dfinke
Copy link
Owner

dfinke commented Apr 19, 2024

Ok, I added you as a maintainer. That was a fun project to build in PowerShell.

What plans do you have for it?

@agracio
Copy link
Author

agracio commented Apr 19, 2024

Thanks!
Don't have any huge plans but first thing is to add .NET Core compiler for use in .NET Core projects and other platforms if they chose to use PowerShell so basically merging https://github.com/agracio/edge-ps-core into it.
And since I am merging both and keeping try directory wanted to add some npm run demoD3 and such to make it easy to run demos and test that everything works at the same time.
EDIT: Will also take a look at the few outstanding issues that are open here, even if they are 10 years old by now no harm in looking into it.

Another item on my TODO list not directly related to edge-ps is to add a second AppVeyor test suite to edge-js that would run all/most language integrations on AppVeyor on edge-js commit to ensure that none of the integrations are broken. This is mostly relevant to when there are significant changes to Edge.Js. but right now it is a very tedious manual process.
Currently AppVeyor CI suite (or local manual runs) only runs internal tests that not always show problems with integrations.

As for citing you as original creator this is an example for edge-py https://github.com/agracio/edge-py. It also keeps license copyright attributed to Tomasz Janczuk and as author in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants