From 6cc68c84082f70c9467635cb5d2b9b22b57120e8 Mon Sep 17 00:00:00 2001 From: David Federman Date: Tue, 12 May 2020 08:22:55 -0700 Subject: [PATCH] Manually integrate unreleased Jasmine fix: https://github.com/jasmine/jasmine/commit/2b318a6154825cc0ad895c8e0c3f7070b74272bc --- package-lock.json | 6 +++--- package.json | 4 ++-- src/lib/adapter.js | 4 ---- src/lib/html.jasmine.reporter.js | 2 ++ 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/package-lock.json b/package-lock.json index 12d7b07..b2f1043 100644 --- a/package-lock.json +++ b/package-lock.json @@ -21,9 +21,9 @@ } }, "chalk": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/chalk/-/chalk-3.0.0.tgz", - "integrity": "sha512-4D3B6Wf41KOYRFdszmDqMCGq5VV/uMAB273JILmO+3jAlh8X4qDtdtgCR3fxtbLEMzSx22QdhnDcJvu2u1fVwg==", + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/chalk/-/chalk-4.0.0.tgz", + "integrity": "sha512-N9oWFcegS0sFr9oh1oz2d7Npos6vNoWW9HvtCg5N1KRFpUhaAhvTv5Y58g880fZaEYSNm3qDz8SU1UrGvp+n7A==", "dev": true, "requires": { "ansi-styles": "^4.1.0", diff --git a/package.json b/package.json index bb32a7c..b830f42 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "karma-jasmine-html-reporter", - "version": "1.5.3", + "version": "1.5.4", "description": "A Karma plugin. Dynamically displays tests results at debug.html page", "main": "./src/index.js", "keywords": [ @@ -52,4 +52,4 @@ "jasmine-core": ">=3.5" }, "readmeFilename": "README.md" -} +} \ No newline at end of file diff --git a/src/lib/adapter.js b/src/lib/adapter.js index e129b0a..495e90e 100644 --- a/src/lib/adapter.js +++ b/src/lib/adapter.js @@ -54,10 +54,6 @@ filterSpecs: filterSpecs }); - /** - * The `jsApiReporter` also receives spec results, and is used by any environment that needs to extract the results from JavaScript. - */ - env.addReporter(htmlReporter); /** diff --git a/src/lib/html.jasmine.reporter.js b/src/lib/html.jasmine.reporter.js index af5a31d..4d05c59 100644 --- a/src/lib/html.jasmine.reporter.js +++ b/src/lib/html.jasmine.reporter.js @@ -350,9 +350,11 @@ jasmineRequire.HtmlReporter = function (j$) { find('.jasmine-failures-menu').onclick = function () { setMenuModeTo('jasmine-failure-list'); + return false; }; find('.jasmine-spec-list-menu').onclick = function () { setMenuModeTo('jasmine-spec-list'); + return false; }; setMenuModeTo('jasmine-failure-list');