Skip to content

Commit d593847

Browse files
authored
Merge pull request #5647 from dfe-analytical-services/EES-5907
Hotfix: EES-5907 Fix frontend/backend request model mismatch
2 parents be4793d + bcdb19b commit d593847

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/GovUk.Education.ExploreEducationStatistics.Data.Api.Tests/Services/PermalinkServiceTests.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public async Task CreatePermalink_WithoutReleaseVersionId()
266266

267267
var request = new PermalinkCreateRequest
268268
{
269-
ReleaseId = null,
269+
ReleaseVersionId = null,
270270
Configuration = new TableBuilderConfiguration
271271
{
272272
TableHeaders = new TableHeaders()
@@ -582,7 +582,7 @@ public async Task CreatePermalink_WithReleaseVersionId()
582582

583583
var request = new PermalinkCreateRequest
584584
{
585-
ReleaseId = releaseVersion.Id,
585+
ReleaseVersionId = releaseVersion.Id,
586586
Configuration = new TableBuilderConfiguration
587587
{
588588
TableHeaders = new TableHeaders()

src/GovUk.Education.ExploreEducationStatistics.Data.Api/Requests/PermalinkCreateRequest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace GovUk.Education.ExploreEducationStatistics.Data.Api.Requests;
88

99
public record PermalinkCreateRequest
1010
{
11-
public Guid? ReleaseId { get; init; }
11+
public Guid? ReleaseVersionId { get; init; }
1212

1313
public TableBuilderConfiguration Configuration { get; init; } = new();
1414

src/GovUk.Education.ExploreEducationStatistics.Data.Api/Services/PermalinkService.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private async Task<Either<ActionResult, Permalink>> Find(Guid permalinkId,
8383
public async Task<Either<ActionResult, PermalinkViewModel>> CreatePermalink(PermalinkCreateRequest request,
8484
CancellationToken cancellationToken = default)
8585
{
86-
return await (request.ReleaseId ?? await FindLatestPublishedReleaseVersionId(request.Query.SubjectId))
86+
return await (request.ReleaseVersionId ?? await FindLatestPublishedReleaseVersionId(request.Query.SubjectId))
8787
.OnSuccess(releaseVersionId =>
8888
{
8989
return _tableBuilderService.Query(releaseVersionId,

0 commit comments

Comments
 (0)