Merge pull request #5488 from dfe-analytical-services/EES-5756

EES-5756 Set DataSetFileMeta geographic levels to null

Author: mmyoungman

src/GovUk.Education.ExploreEducationStatistics.Admin/Controllers/Api/DataSetFileGeographicLevelsMigrationController.cs src/GovUk.Education.ExploreEducationStatistics.Admin/Controllers/Api/DataSetFileMetaMigrationController.cs

@@ -1,9 +1,7 @@
-using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using GovUk.Education.ExploreEducationStatistics.Admin.Models;
-using GovUk.Education.ExploreEducationStatistics.Common.Extensions;
 using GovUk.Education.ExploreEducationStatistics.Common.Model;
 using GovUk.Education.ExploreEducationStatistics.Content.Model;
 using GovUk.Education.ExploreEducationStatistics.Content.Model.Database;
@@ -21,18 +19,19 @@ public class MigrationResult
     {
         public bool IsDryRun;
         public int Processed;
-        public string Errors;
+        public int NumLeftToProcess;
     }
 
-    [HttpPut("bau/migrate-datasetfile-geographiclevels")]
+    [HttpPut("bau/meta-geographic-levels-remove")]
     public async Task<MigrationResult> DataSetFileVersionGeographicLevelsMigration(
         [FromQuery] bool isDryRun = true,
         [FromQuery] int? num = null,
         CancellationToken cancellationToken = default)
     {
         var queryable = contentDbContext.Files
             .Where(f => f.Type == FileType.Data
-                        && f.DataSetFileVersionGeographicLevels.Count == 0);
+                        && f.DataSetFileMetaGeogLvlMigrated == false
+                        && f.DataSetFileVersionGeographicLevels.Count > 0); // Paranoidly protecting against data set where geog lvls aren't migrated
 
         if (num != null)
         {
@@ -42,30 +41,21 @@ public async Task<MigrationResult> DataSetFileVersionGeographicLevelsMigration(
         var files = queryable.ToList();
 
         var numProcessed = 0;
-        List<string> errors = [];
 
         foreach (var file in files)
         {
-            var meta = file.DataSetFileMeta;
-
-            if (meta == null)
+            if (file.DataSetFileMeta != null)
             {
-                errors.Add($"No DataSetFileMeta found for File {file.Id}");
-                continue;
-            }
-
-            var dataSetFileVersionGeographicLevels = meta!.GeographicLevels
-                .Distinct()
-                .Select(gl => new DataSetFileVersionGeographicLevel
+                file.DataSetFileMeta = new DataSetFileMeta
                 {
-                    DataSetFileVersionId = file.Id,
-                    GeographicLevel = gl,
-                })
-                .ToList();
-
-            contentDbContext.DataSetFileVersionGeographicLevels.AddRange(
-                dataSetFileVersionGeographicLevels);
+                    GeographicLevels = null,
+                    TimePeriodRange = file.DataSetFileMeta.TimePeriodRange,
+                    Filters = file.DataSetFileMeta.Filters,
+                    Indicators = file.DataSetFileMeta.Indicators,
+                };
+            }
 
+            file.DataSetFileMetaGeogLvlMigrated = true;
             numProcessed++;
         }
 
@@ -78,7 +68,7 @@ public async Task<MigrationResult> DataSetFileVersionGeographicLevelsMigration(
         {
             IsDryRun = isDryRun,
             Processed = numProcessed,
-            Errors = errors.IsNullOrEmpty() ? "No errors" : errors.JoinToString("\n"),
+            NumLeftToProcess = contentDbContext.Files.Count(f => f.DataSetFileMetaGeogLvlMigrated == false),
         };
     }