Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob data start/end reference issues #1288

Open
zhenyanghua opened this issue Apr 23, 2021 · 1 comment
Open

Blob data start/end reference issues #1288

zhenyanghua opened this issue Apr 23, 2021 · 1 comment

Comments

@zhenyanghua
Copy link

https://github.com/dfahlander/Dexie.js/blob/b6d621ef25075f4f54cfdd923834bf939351cd93/addons/dexie-export-import/src/tson.ts#L74

The above reference causes blob type finalize method to always provide the full bytes instead of the sliced bytes.

https://github.com/dfahlander/Dexie.js/blob/b6d621ef25075f4f54cfdd923834bf939351cd93/addons/dexie-export-import/src/tson.ts#L40

From the above reference we could tell the start and end properties belong to data instead of the blob.

The fixes is to correct the reference.
@zhenyanghua
Copy link
Author

#1271 for tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhenyanghua