Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown should be supported #1523

Closed
liyimeng opened this issue Aug 14, 2019 · 3 comments · Fixed by #1991
Closed

Graceful shutdown should be supported #1523

liyimeng opened this issue Aug 14, 2019 · 3 comments · Fixed by #1991
Labels
help wanted kind/enhancement
Milestone
v2.28.0

Comments

@liyimeng
Copy link

Today, dex dose not handle any signal from user or kubernetes. This might cause some resource open when dex process are killed, e.g. the storage.Close function never get called.
@liyimeng liyimeng mentioned this issue Aug 31, 2019
Closed
@sagikazarmark sagikazarmark mentioned this issue Jan 15, 2021
Closed
@nabokihms
Copy link
Member

I think this issue was resolved in #1942

@sagikazarmark
Copy link
Member

Hm, is storage.Close also called somewhere?

@nabokihms
Copy link
Member

I don't think so 😅 . Looks like we have to add it.

@nabokihms nabokihms mentioned this issue Feb 12, 2021
Merged
@sagikazarmark sagikazarmark added this to the v2.28.0 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted kind/enhancement
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging a pull request may close this issue.

fix: close storage on shutdown deckhouse/3p-dex
4 participants
@srenatus @sagikazarmark @liyimeng @nabokihms