Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add grpc as a peer dependency? #36

Open
c3s4r opened this issue Apr 27, 2017 · 2 comments
Open

Should we add grpc as a peer dependency? #36

c3s4r opened this issue Apr 27, 2017 · 2 comments

Comments

@c3s4r
Copy link
Member

c3s4r commented Apr 27, 2017

Adding grpc as a peer dependency would allow users to update grpc versions anytime without updating condor-framework.
@c3s4r
Copy link
Member Author

c3s4r commented Apr 27, 2017 •
edited
Loading

This is a change that would break existing implementation. It will need more discussion. For now I'm just changing grpc version to the latest (1.2.4 at the moment of writing). Change available in condor-framework 1.2.1.

@c3s4r c3s4r changed the title Add grpc as a peer dependency Should we add grpc as a peer dependency? May 16, 2017
@sgraham785
Copy link

any more thoughts on this? now grpc is 1.4.1 and condor is "grpc": "~1.3.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c3s4r @sgraham785