Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove twitter handle link if it doesn't exist #366

Closed
bridgetkromhout opened this issue May 16, 2016 · 0 comments · Fixed by #529
Closed

remove twitter handle link if it doesn't exist #366

bridgetkromhout opened this issue May 16, 2016 · 0 comments · Fixed by #529
Assignees
@yvovandoorn

Comments

@bridgetkromhout
Copy link
Collaborator

We're just linking a @ to twitter.com if there's no twitter handle, from:

https://github.com/devopsdays/devopsdays-web/blob/master/themes/devopsdays-legacy/layouts/speakers/single.html#L20

and

https://github.com/devopsdays/devopsdays-web/blob/master/themes/devopsdays-legacy/layouts/talk/single.html#L29

This needs a better fallthrough for leaving this out if not set. Related to #365. Heads up to @yvovandoorn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yvovandoorn yvovandoorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't display Twitter "@" when handle isn't set devopsdays/devopsdays-web
3 participants
@mattstratton @bridgetkromhout @yvovandoorn