Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Consider processing sponsor image sizes in gulp #153

Closed
mattstratton opened this issue Jan 31, 2017 · 4 comments
Closed

Consider processing sponsor image sizes in gulp #153

mattstratton opened this issue Jan 31, 2017 · 4 comments
Assignees
@mattstratton
Labels
bug workflow
Milestone
1.0 Release

Comments

@mattstratton
Copy link
Member

They're generally pretty small, so we can probably skip them for that processing.
@mattstratton mattstratton self-assigned this Jan 31, 2017
@mattstratton mattstratton added this to the v1.0 Release milestone Jan 31, 2017
@mattstratton
Copy link
Member Author

Thinking about this some more, it might be actually more useful to put special processing on the sponsor images to size them properly - we can then not have to make people put in a specific size, and we can resize them with the responsive thing to the width that we need for each viewport.

@mattstratton mattstratton changed the title Sponsor images are not worth retina Consider processing sponsor image sizes in gulp Feb 17, 2017
@bridgetkromhout
Copy link
Contributor

Is this necessary for v1.0?

@mattstratton
Copy link
Member Author

Goes with the other image processing fix for homepage. So yep.

This was referenced Feb 20, 2017
Closed
Closed
@mattstratton mattstratton mentioned this issue Feb 20, 2017
Merged
@mattstratton
Copy link
Member Author

Fixed in #270

@ghost ghost removed the in progress label Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mattstratton mattstratton

Labels
bug workflow
Projects
None yet
Milestone
1.0 Release
Development

No branches or pull requests
2 participants
@mattstratton @bridgetkromhout