Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comparison with other libraries for peak detection #10

Closed
LegrandNico opened this issue Sep 13, 2023 · 1 comment
Closed

add comparison with other libraries for peak detection #10

LegrandNico opened this issue Sep 13, 2023 · 1 comment

Comments

@LegrandNico
Copy link

As the added value of the package is to facilitate the use of machine learning and deep learning methods to analyse ECG signal, it would be useful to see how this relate to other methods, especially methods that are simpler. I would suggest a comparison with the peak detection algorithms provided by Neurokit2 and SleepECG.

This issue is related to the review of the package for JOSS (see here).

@devnums
Copy link
Owner

devnums commented Sep 21, 2023

Thank you for your suggestion. I have edited the paper, please take a look at it here and let me know if that's what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants