Watch included templates #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2018 07:39
…emplate is in the root of your project
This reverts commit 1adc6ba.
|
Looks good. Thanks for the help! |
This was referenced Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, great plugin!
Currently, parcel doesn't watch for changes in included nunjucks templates, i.e.:
This change walks the directory of the base nunjucks file and adds any templates it finds with the
.njkextension to parcel's dependencies.This is basically so you get auto-reloading in parcel as you're editing templates...
Also added a quick line to the README that the plugin requires your nunjucks templates have extension
.njk, which wasn't totally clear to me when I first installed the plugin.