Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta namespace update #126

Closed
Maxouwell opened this issue Oct 25, 2023 · 6 comments
Closed

Jakarta namespace update #126

Maxouwell opened this issue Oct 25, 2023 · 6 comments

Comments

@Maxouwell
Copy link
Contributor

Hello,

Would you take a PR on a jakarta update for addJPAAnnotations and addJavaxAnnotations ?

I'm thinkinf of

  • For addJPAAnnotations, simply adding jakarta.* annotation search in JPAAnalyzerHelper and allowing both on the doc
  • For addJavaxAnnotations, doing one or more of :
    • Renaming the parameter to addJavaBeanAnnotations (breaking change, but I may be the only one using it)
    • Renaming the docs to addJavaBeanAnnotations
    • Adding jakarta.* annotation search in JavaxValidationAnalyzerHelper

What do you think ?
Regards

@devlauer
Copy link
Owner

An additional consideration of the jakarta namespace makes sense, because sooner or later all users switch to it.
That you rename in this case the method addJavaxAnnotations as well as the associated internal methods and the class JavaxValidationAnalyzerHelper likewise. Regarding the breaking change I would like to see a hint in the documentation, so that other potential users know what to change to.
In this respect I would adopt the PR.

@Maxouwell
Copy link
Contributor Author

Hello !

Not a lot of time on my hand lately, I made a PR for the (easy) JPA Annotation part : #140

Let me know !

@devlauer
Copy link
Owner

Sorry for the delayed answer! Thanks you very much for your contribution! I've merged your PR and created a new version (2.4.0), which should be available in the next hours.

@Maxouwell
Copy link
Contributor Author

Well it's was not that easy since I botched a part.
Fixed in #205

@Maxouwell
Copy link
Contributor Author

And as I was on it, #206 for adding the jakarta Validation part

@devlauer
Copy link
Owner

@Maxouwell : Thank you very much for your contribution! And I am really sorry for the long wait!
I released both pull requests as part of version 3.0.1. This version should be available within the next hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants