Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing font icons (plain/line version) #248

Closed
12 tasks done
amacado opened this issue Jul 4, 2020 · 5 comments · Fixed by #394
Closed
12 tasks done

Fix missing font icons (plain/line version) #248

amacado opened this issue Jul 4, 2020 · 5 comments · Fixed by #394
Assignees
Labels
bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue

Comments

@amacado
Copy link
Member

amacado commented Jul 4, 2020

The following icons keep missing a plain/line version and therefore not beeing displayed properly on the gh-page (see screenshot below).

  • clojure
  • clojurescript
  • ember
  • mocha
  • npm
  • redux
  • yunohost
  • bitbucket
  • sourcetree
  • confluence
  • ssh
  • twitter

image

@amacado amacado added bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue labels Jul 4, 2020
@amacado amacado self-assigned this Jul 4, 2020
@amacado amacado removed their assignment Sep 7, 2020
@Thomas-Boi Thomas-Boi self-assigned this Sep 11, 2020
@Thomas-Boi
Copy link
Member

Everything has been fixed. There are two special cases: npm and ember. They only have 1 SVG and while those are colorful, they are also used as icons. This is possible because Icomoon can actually strip colors from SVGs.

@amacado
Copy link
Member Author

amacado commented Dec 12, 2020

I will reopen this issue, since some icons are still missing (updated the list on top of this issue)

@Thomas-Boi
Copy link
Member

I made a mistake regarding the icons. Turns out that while some icons are missing svg files, others have the wrong data entered into the devicon.json.

For example,
image

Twitter has a "plain" version listed. However, in the folder, there is only an "original" version. Updating it to "original" fix the issue
image

There's also an issue within the HTML file itself. In the script.js, the bottom two versions didn't exist before I fix it:
image

This caused ember to not be displayed because ember only has an "original-wordmark" version:
image

So I went through every single icons that you have in the list. I have fixed all of them and they now show up in the index.html. I'll push my change in a new PR and link this issue to it.

@Thomas-Boi Thomas-Boi linked a pull request Dec 15, 2020 that will close this issue
This was referenced Dec 15, 2020
@Thomas-Boi
Copy link
Member

Hey @amacado is this issue done? Can we close this one now?

@amacado
Copy link
Member Author

amacado commented Jan 5, 2021

You're right, can be closed. Thanks! :) Fixed in v2.8+

@amacado amacado closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants