From 921dd884c0dd359d34c7925859d7424f90e5a4e6 Mon Sep 17 00:00:00 2001 From: Thomas Bui Date: Sun, 28 Mar 2021 21:27:01 -0700 Subject: [PATCH 1/2] Check svg now fails if there's error and updated CONTRIBUTING --- .github/workflows/post_check_svgs_comment.yml | 33 +++++++++++-------- CONTRIBUTING.md | 11 ++++++- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/.github/workflows/post_check_svgs_comment.yml b/.github/workflows/post_check_svgs_comment.yml index cce4eba31..25dcacf68 100644 --- a/.github/workflows/post_check_svgs_comment.yml +++ b/.github/workflows/post_check_svgs_comment.yml @@ -35,21 +35,21 @@ jobs: with: path: ./svg_err_messages/svg_err_messages.txt - - name: Comment on the PR about the result - Success - uses: jungwinter/comment@v1 # let us comment on a specific PR - if: success() && steps.err_message_reader.outputs.content == '1' - env: - MESSAGE: | - Hi! - I'm Devicons' SVG-Checker Bot and everything looks great. Good job! + # - name: Comment on the PR about the result - Success + # uses: jungwinter/comment@v1 # let us comment on a specific PR + # if: success() && steps.err_message_reader.outputs.content == '1' + # env: + # MESSAGE: | + # Hi! + # I'm Devicons' SVG-Checker Bot and everything looks great. Good job! - Have a nice day, - SVG-Checker Bot :grin: - with: - type: create - issue_number: ${{ steps.pr_num_reader.outputs.content }} - token: ${{ secrets.GITHUB_TOKEN }} - body: ${{ env.MESSAGE }} + # Have a nice day, + # SVG-Checker Bot :grin: + # with: + # type: create + # issue_number: ${{ steps.pr_num_reader.outputs.content }} + # token: ${{ secrets.GITHUB_TOKEN }} + # body: ${{ env.MESSAGE }} - name: Comment on the PR about the result - SVG Error uses: jungwinter/comment@v1 # let us comment on a specific PR @@ -79,6 +79,11 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} body: ${{ format(env.MESSAGE, steps.err_message_reader.outputs.content) }} + # if we posted error messages before, we fail this entire workflow + - name: Fail workflow is there is an error. + uses: cutenode/action-always-fail@v1.0.1 + if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1') + - name: Comment on the PR about the result - Failure uses: jungwinter/comment@v1 # let us comment on a specific PR if: failure() diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 89b141f32..f0b37fa39 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -29,7 +29,7 @@ First of all, thanks for taking the time to contribute! This project can only gr

Overview on Submitting Icons

-

Here is an overview of what you have to do to submit your icons to the repo.

+

Here is what you have to do to submit your icons to the repo.

  1. Create the svgs for each svg versions that you have
  2. Put the svgs of each Icon into its own folders in /icons
    3. @@ -44,6 +44,15 @@ First of all, thanks for taking the time to contribute! This project can only gr

    Versions and Naming Conventions

    +

    For the technology name, make the file and folder name lowercase and concatenate them. For example:

    + +
    +

    Each icon/svg can come in different versions. So far, we have:

    -

    Each icon/svg can come in different versions. So far, we have:

    @@ -84,7 +82,7 @@ First of all, thanks for taking the time to contribute! This project can only gr

    Before you submit your logos/svgs, please ensure that they meet the following standard: