Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable proxy support for DevWorkspaces #678

Closed
Tracked by #20830
amisevsk opened this issue Nov 18, 2021 · 5 comments · Fixed by #711
Closed
Tracked by #20830

Enable proxy support for DevWorkspaces #678

amisevsk opened this issue Nov 18, 2021 · 5 comments · Fixed by #711
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

Currently, DevWorkspaces have no way to specify proxy settings, so built-in containers such as project-clone will fail to clone projects if running behind a proxy. We need to define a way to specify proxy settings and figure out how to propagate these down to the workspace pods.

Additional context

Originally brought as a CRW integration issue: https://issues.redhat.com/browse/CRW-2473

@amisevsk
Copy link
Collaborator Author

cc: @ibuziuk @l0rd this is likely a milestone 3 issue

@l0rd
Copy link
Collaborator

l0rd commented Nov 22, 2021

Milestone 3 issue for that was: eclipse-che/che#20386

This is mainly about injecting environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY and mounting the trusted certificates bundle. Che operator should do the heavy lifting: create the ConfigMaps containing variables and bundle in users namespaces. Then the DevWorkspace should mount them in workspaces containers. That should already work. @skabashnyuk hasn't that work been completed yet?

@skabashnyuk
Copy link

in Eclipse Che we have this eclipse-che/che-operator#1027

@metlos
Copy link
Contributor

metlos commented Nov 23, 2021

yes, mounting of proxy settings to workspace containers should already work. This issue is about supporting that also in built-in containers, is that right? I am al little bit out of the loop on DWO capabilities, so I didn't realize project clone happens in DWO and so is affected by this, too.

@l0rd
Copy link
Collaborator

l0rd commented Nov 23, 2021

@metlos cloning happens in initContainers, the mechanism that works for regular containers should work for init containers too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants