Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control over how rsync and start/stop happens #60

Closed
maxandersen opened this issue Jun 2, 2020 · 2 comments
Closed

control over how rsync and start/stop happens #60

maxandersen opened this issue Jun 2, 2020 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@maxandersen
Copy link

maxandersen commented Jun 2, 2020

/kind feature

Which functionality do you think we should add?

Being able to customize in devfile what folders are rsynced to not only support in-cluster source builds but be able to take locally built artifacts and put in a specific location on the deployment.

Why is this needed?

to support wildfly, tomcat, nodejs or any other runtime that supports true incremental hotdeploy of resources (wether source or binaries) (quarkus will support this in upcoming releases)

Advantages:

  • speed - allows us to fully skip the in cluster build.
  • experimentation - one can do local changes and experiments not necessarily encoded in pom.xml etc. yet
  • local vs remote are in sync; less surprises during development
  • can be used to focus source based builds too to save time

disadvantages:

  • makes non-reproducible builds (but that is the same today where you don't need to commit to see changes)

originally opened at redhat-developer/odo#3132 but asked to also open here.

@l0rd l0rd added the kind/enhancement New feature or request label Jun 8, 2020
@l0rd
Copy link
Contributor

l0rd commented Jun 9, 2020

Volume is the mechanism that allow sharing files amongst components of a Devfile (see the v2.0 issue about that). And mountSources: true is a simple way to include sources (i.e. projects) in a component.

@l0rd
Copy link
Contributor

l0rd commented Jun 24, 2020

Closing this hot reload part is tracked in issue #64 and the folders to sync (using rsync or whatever) can currently be specified with volumes.

@l0rd l0rd closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants