Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull and parse parent devfile from Kubernetes CRD in library #355

Closed
yangcao77 opened this issue Feb 23, 2021 · 2 comments · Fixed by devfile/library#78
Closed

Pull and parse parent devfile from Kubernetes CRD in library #355

yangcao77 opened this issue Feb 23, 2021 · 2 comments · Fixed by devfile/library#78
Assignees
Labels
area/library Common devfile library for interacting with devfiles

Comments

@yangcao77
Copy link
Contributor

Currently devfile library can only parse parent devfile if uri is specified.

This issue is to support Kubernetes CRD defined under parent.
(Question: should be with type DevWorkspaceTemplate or DevWorkspace ??)

Needs to get KubeConfig and creates Kubernetes client, and access the Kubernetes CRD from that client.

The parent devfile should be parsed & override & merge into the flattened devfile.

@yangcao77 yangcao77 added the area/library Common devfile library for interacting with devfiles label Feb 23, 2021
@maysunfaisal
Copy link
Member

Before starting we should check with the devworkspace operator repo and if they have logic in place for this issue already and needs consolidation..

@yangcao77
Copy link
Contributor Author

Talked with Angel, devworkspace operator now gets plugin from CRD via the same mechanism. They are going to help port over the common functions(get KubeConfig and creates Kubernetes client, and access the Kubernetes CRD from that client) & tests into library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants