Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Investigate api repo for arm64 support #1378

Closed
2 tasks
Jdubrick opened this issue Dec 11, 2023 · 2 comments
Closed
2 tasks

[Spike] Investigate api repo for arm64 support #1378

Jdubrick opened this issue Dec 11, 2023 · 2 comments
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification devtools-week

Comments

@Jdubrick
Copy link
Contributor

Which area/kind this issue is related to?

/area api
Devtools week

Issue Description

As part of devtools week and in order to provide support for multiple architectures, investigation will need to be done into the api repository to ensure that there is sufficient support for both amd64 and arm64 architectures. This investigation stems from issues regarding arm64 support in other repos.

Criteria

  • Investigate whether any changes will need to be made to this repository to fully support arm64 architecture
  • Open necessary issues for any changes that need to be made
@openshift-ci openshift-ci bot added the area/api Enhancement or issue related to the api/devfile specification label Dec 11, 2023
@Jdubrick Jdubrick self-assigned this Dec 11, 2023
@Jdubrick
Copy link
Contributor Author

After some testing I can confirm that the bash ./docker-run.sh ./build.sh command works for arm64 architecture (as I am on it), without issue. During my investigation however I did notice that when trying to run bash ./build/typescript-model/generate.sh I was given an error related to the -m flag for readLink. After some digging I think that the -m flag may not be supported on MacOS in general, and a workaround could be shifting the implementation away from readLink -m to readLink -f or realPath

@Jdubrick
Copy link
Contributor Author

Opened #1380 due to my findings. I don't think this issue is due to the arm64 architecture and rather may be affecting those on MacOS in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification devtools-week
Projects
Status: Done ✅
Development

No branches or pull requests

1 participant