Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate API's generator potential improvements #1359

Open
1 task
thepetk opened this issue Nov 22, 2023 · 3 comments
Open
1 task

Investigate API's generator potential improvements #1359

thepetk opened this issue Nov 22, 2023 · 3 comments
Labels
area/api Enhancement or issue related to the api/devfile specification lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@thepetk
Copy link
Contributor

thepetk commented Nov 22, 2023

Which area/kind this issue is related to?

/area api

Issue Description

As seen in the #1345 after the upgrade to go 1.19 the generator module is now using the -mod=mod while having a fixed version of the sigs.k8s.io/controller-tools/cmd/helpgen package. For example it generates the code through:

go:generate go run -mod=mod sigs.k8s.io/controller-tools/cmd/helpgen@v0.6.2 
generate:headerFile=../header.go.txt,year=2020 paths=.

As a result, this update skips the usage of vendor directory for this dependency. As part of this issue we should investigate any potential workarounds on how we can generate the code while using only the vendor directory.

Acceptance Criteria

  • Investigate any potential workaround on using go generate with the usage only of vendor dir.
@openshift-ci openshift-ci bot added the area/api Enhancement or issue related to the api/devfile specification label Nov 22, 2023
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Feb 21, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Feb 21, 2024

This is still a requirement

@thepetk thepetk removed the lifecycle/stale Stale items. These items have not been updated for 90 days. label Feb 21, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
None yet
Development

No branches or pull requests

1 participant