Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove post-stop event from the devfile spec #1032

Closed
l0rd opened this issue Feb 14, 2023 · 2 comments
Closed

Remove post-stop event from the devfile spec #1032

l0rd opened this issue Feb 14, 2023 · 2 comments
Labels
area/api Enhancement or issue related to the api/devfile specification lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 14, 2023

Which area this feature is related to?

/area api

Which functionality do you think we should add?

We want to remove the  post-stop event as this is hasn't been implemented and there are no known valid use case for it.

Why is this needed? Is your feature request related to a problem?

Having both pre-stop and post-stop is confusing.
Implementing post-stop may be challeging.
@openshift-ci openshift-ci bot added the area/api Enhancement or issue related to the api/devfile specification label Feb 14, 2023
@l0rd l0rd mentioned this issue Feb 15, 2023
Closed
@l0rd l0rd self-assigned this Feb 18, 2023
@l0rd l0rd mentioned this issue Mar 6, 2023
Closed
7 tasks
@l0rd l0rd mentioned this issue Mar 22, 2023
Closed
@l0rd l0rd removed their assignment Apr 5, 2023
@michael-valdron
Copy link
Member

We should deprecate the field first and remove after several version of deprecation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Aug 4, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Enhancement or issue related to the api/devfile specification lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days. sprint/current
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l0rd @michael-valdron