Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Field Number - fix width of horizontal stepper variant #932

Closed
2 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Feb 19, 2024 · 3 comments · Fixed by #1152
Closed
2 tasks done
Tracked by #452

Input Field Number - fix width of horizontal stepper variant #932

thrbnhrtmnn opened this issue Feb 19, 2024 · 3 comments · Fixed by #1152
Assignees
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Feb 19, 2024

Description / User story

The width of the stepper buttons in the stepper variant "horizontal" of the Input Field Number is not aligned between design and code.

In design the each stepper button should be squared (i.e. 32x32 in SM), but in code the width is smaller than it should be and even changes when the width of the wrapping container of the Input Field Number changes.

The width in code should be aligned with the width in design.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • The width of the Stepper Buttons in the "horizontal" stepper variant of the Input Field Number is the same in code as in design (32 px in SM, 40 px in MD and 48 px in LG)

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Feb 19, 2024
@AnukratiMehta
Copy link

I'd like to give this a try @thrbnhrtmnn.

@thrbnhrtmnn
Copy link
Contributor Author

Hey @AnukratiMehta , thanks for reaching out and for wanting to contribute to the project!

Unfortunately we are currently doing a massive update to our CSS, so I would highly recommend to wait a bit before starting this issue. We probably will finish it this week, maybe even today. I will let you know when this can be started :-)

@thrbnhrtmnn
Copy link
Contributor Author

Hello @AnukratiMehta , it took a bit longer, but we just finished the CSS update. If you still want to give this a try, please go ahead :-)

@thrbnhrtmnn thrbnhrtmnn changed the title Number Input - align width of horizontal stepper variant Number Input - fix width of horizontal stepper variant Feb 27, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Number Input - fix width of horizontal stepper variant Input Field Number - fix width of horizontal stepper variant Mar 26, 2024
@bar-tay bar-tay self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants