Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Quality with CSS Mixins for input components #922

Open
1 of 6 tasks
thrbnhrtmnn opened this issue Feb 15, 2024 · 0 comments
Open
1 of 6 tasks

Improve Code Quality with CSS Mixins for input components #922

thrbnhrtmnn opened this issue Feb 15, 2024 · 0 comments
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Feb 15, 2024

Description / User story

One way to imrpove our code quality and make the code better readable and maintainable we want to use CSS mixins. A good starting point would be to implement this for all input components.

A good example here would be the blr-form-element element, which we are using in multiple places already.

The benefit is also, that this will help us to be more consistent within our components. When we did #564 , it became clear that we are not as consistent as we want to be.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • Repeating CSS in input components that can be replaced with CSS Mixins has been identified
  • CSS Mixins are implemented for input components
    • blr-form-element is used via mixins
    • foxus-ring is used via mixins
    • ...

Additional information

  • We also have other approaches that could lead to the same result, clear direction is not decided yet

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn changed the title Implement Mixins Implement CSS Mixins Feb 15, 2024
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Feb 15, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Feb 21, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Mar 8, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Implement CSS Mixins Improve Code Quality with CSS Mixins for input components Mar 13, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Improve Code Quality milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant