Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - add hasLabel prop in code #883

Closed
7 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Feb 6, 2024 · 1 comment
Closed
7 tasks done
Tracked by #452

Select - add hasLabel prop in code #883

thrbnhrtmnn opened this issue Feb 6, 2024 · 1 comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Feb 6, 2024

Description / User story

We should add the "hasLabel" prop to the select, which is also used in other form components like Text Input, Text Area, Checkbox or Number Input.

If hasLabel is true, the Label (incl. its bottom padding) should be shown. If hasLabel is false, the Label and its bottom padding is not displayed.

In the props panel in Storybook the "hasLabel" prop also controls of the label or the labelAppendix props are shown (hasLabel=true) or not (hasLabel=false).

Requirements / Prerequisites

  • no open requirements

Acceptance Criteria

  • The hasLabel prop is added to the Select component
  • If hasLabel = true, the label incl. its bottom padding are displayed
  • If hasLabel = false, the label incl. its bottom padding are not displayed
  • The label and labelAppendix prop in the props panel in Storybook are only displayed to the user if hasLabel=true
  • The order of the props is as defined in the Props Excel
  • The Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Feb 6, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Issue is already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors
Projects
None yet
Development

No branches or pull requests

1 participant