Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio - fix checked and error states #765

Closed
5 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Jan 11, 2024 · 7 comments
Closed
5 tasks done
Tracked by #452

Radio - fix checked and error states #765

thrbnhrtmnn opened this issue Jan 11, 2024 · 7 comments
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jan 11, 2024

Description / User Story

Describe the ticket here or formulate a user story as follows:

This issue fixes current issues with checking the control of the radio. Currently this is not possible. Also it should not be possible in Readonly. Furthermore it should be possible in error state.


Acceptance Criteria

  • The radio can be checked by either setting checked to true or clicking the control
  • Prevent click in readOnly,; focusing the control is still possible, but will not check the control
  • Allow active option in error state and use the correct tokens
  • The Hover state for selected/checked radio is also working as defined in design
  • The Pressed state for selected/checked radio is also working as defined in design

Background information

  • Add relevant information here
  • ...
@seemann
Copy link
Contributor

seemann commented Jan 18, 2024

We should discuss if the read-only status makes sense. The read-only attribute is not a standard for input radios.

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly

Bildschirmfoto 2024-01-18 um 14 42 18

@larserbach larserbach self-assigned this Jan 18, 2024
@seemann
Copy link
Contributor

seemann commented Jan 25, 2024

The fix for the uncheckable radios and the styling issues is merged.
The topic regarding the read-only state should be fixed in another ticket.

@thrbnhrtmnn
Copy link
Contributor Author

thrbnhrtmnn commented Jan 25, 2024

Hey @seemann , I agree to slice out the read-only topic into a new ticket (#832). But I also found an issue with the current implementation. It seems to me that the pressed state is not implemented as defined in design. At least I could not make it work. Can you have a look at that again?

@thrbnhrtmnn thrbnhrtmnn removed the 🚫 blocked This issue is blocked label Jan 25, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Radio - fix checked, readonly and error states Radio - fix checked, ~readonly~ and error states Jan 25, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Radio - fix checked, ~readonly~ and error states Radio - fix checked and error states Jan 25, 2024
@seemann
Copy link
Contributor

seemann commented Jan 25, 2024

Hey @thrbnhrtmnn, is it not this one?

Bildschirmaufnahme.2024-01-25.um.12.21.09.mov

@thrbnhrtmnn
Copy link
Contributor Author

Hey @seemann , oh yes this looks correct. I did not see that, because I only pressed the control element. This does not seem to have the correct effect.

@larserbach , am I correctly assuming that the pressed (and all other states) should also be triggered when interacting with the control? Please verify this :-)

Another question I now have is, if the effects should also be triggered when hovering/clicking/pressing the gap in-between the control and the label. Currently this is not the case in code.

@thrbnhrtmnn thrbnhrtmnn added ⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers and removed 💚 contributor issue Good for contributors labels Feb 1, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Added design label and changed type to dev & design, as a decision from design is still open.

@thrbnhrtmnn thrbnhrtmnn removed the 🎨 design issue Task is for designers label Feb 8, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Last AC has been moved to #1073.

This issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Projects
None yet
Development

No branches or pull requests

3 participants