-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio - fix checked and error states #765
Comments
We should discuss if the read-only status makes sense. The read-only attribute is not a standard for input radios. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly |
The fix for the uncheckable radios and the styling issues is merged. |
Hey @thrbnhrtmnn, is it not this one? Bildschirmaufnahme.2024-01-25.um.12.21.09.mov |
Hey @seemann , oh yes this looks correct. I did not see that, because I only pressed the control element. This does not seem to have the correct effect. @larserbach , am I correctly assuming that the pressed (and all other states) should also be triggered when interacting with the control? Please verify this :-) Another question I now have is, if the effects should also be triggered when hovering/clicking/pressing the gap in-between the control and the label. Currently this is not the case in code. |
Added design label and changed type to dev & design, as a decision from design is still open. |
Last AC has been moved to #1073. This issue can be closed now. |
Description / User Story
Describe the ticket here or formulate a user story as follows:
This issue fixes current issues with checking the control of the radio. Currently this is not possible. Also it should not be possible in Readonly. Furthermore it should be possible in error state.
Acceptance Criteria
Prevent click in readOnly,; focusing the control is still possible, but will not check the controlThe Pressed state for selected/checked radio is also working as defined in designBackground information
The text was updated successfully, but these errors were encountered: