Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextArea - fix scrolling #712

Closed
Tracked by #452
thrbnhrtmnn opened this issue Dec 18, 2023 · 3 comments · Fixed by #791
Closed
Tracked by #452

TextArea - fix scrolling #712

thrbnhrtmnn opened this issue Dec 18, 2023 · 3 comments · Fixed by #791
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Dec 18, 2023

Step-by-Step Guide to reproduce

The issue seems to only be happening in Firefox. On Chrome and Safari it is working as intended right now.

  1. Navigate to https://b01ler.onrender.com/?path=/docs/design-system-web-components-forms-text-area--docs or https://b01ler.onrender.com/js-example-app
  2. Find textarea
  3. Ensure the Text Area is small enough, so scrolling will be enabled when enter some text (by reducing the size)
  4. Start typing
  5. See that once a few lines are filled with a value, the Text Area is scrolling up and down with every new input
Screen.Recording.2023-12-15.at.18.34.09.mov

Bug Description / False Behaviour

TextArea scrolls up and down, when it should not.


Correct Behaviour

TextArea scroll as expected.


Testing

Check existing unit tests of the component(s) and adjust the tests to prevent this bug from occurring again in the future, if you see a way.


Background

  • ...
@thrbnhrtmnn thrbnhrtmnn added 🚨 new::bug Something isn't working ⌨️ dev issue Task is for developers labels Dec 18, 2023
@thrbnhrtmnn thrbnhrtmnn added the 🦹 needs:specs Further information is requested label Jan 4, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Hey @larserbach , I created the issue, but I could not replicate the behaviour from the video, could you add more information about the issue to the description?

@thrbnhrtmnn thrbnhrtmnn added 💚 contributor issue Good for contributors and removed 🦹 needs:specs Further information is requested labels Jan 4, 2024
@JpunktWpunkt
Copy link
Contributor

JpunktWpunkt commented Jan 4, 2024

I searched for the error and found out: If I remove the keyup event on line 165 in the index.ts which update the counter, then it works well. Maybe this event could be adapted or like that?
Update:
I try this [fix/712-fix-scrolling] (https://github.com/deven-org/B01LER-Kitchen/tree/fix/712-fix-scrolling)

@thrbnhrtmnn thrbnhrtmnn added 📋 task::planned ⭕ core team issue This is for the core team and should not be done by contributors and removed 💚 contributor issue Good for contributors 📋 task::planned labels Jan 5, 2024
@JpunktWpunkt JpunktWpunkt linked a pull request Jan 18, 2024 that will close this issue
@thrbnhrtmnn
Copy link
Contributor Author

After merge we can move this to done as complete. No open topics from the design review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants