Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton & IconButton - remove href and target prop #674

Closed
4 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Dec 5, 2023 · 1 comment
Closed
4 tasks done
Tracked by #452

TextButton & IconButton - remove href and target prop #674

thrbnhrtmnn opened this issue Dec 5, 2023 · 1 comment
Assignees
@seemann
Labels
⌨️ dev issue Task is for developers
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Dec 5, 2023 •
edited by seemann
Loading

Description / User Story

Href and target prop should be removed, as buttons will not have link functionality until later.

Acceptance Criteria

  • href prop has been removed from TextButton
  • href prop has been removed from LinkButton
  • target prop has been removed from TextButton
  • target prop has been removed from LinkButton

Background information

  • ...
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Dec 5, 2023
Open
@seemann seemann self-assigned this Dec 18, 2023
@seemann
Copy link
Contributor

seemann commented Dec 20, 2023

It seems that these components have never had these properties. So we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seemann seemann

Labels
⌨️ dev issue Task is for developers
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

No branches or pull requests
2 participants
@seemann @thrbnhrtmnn