Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox - add required prop #673

Closed
3 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Dec 5, 2023 · 2 comments · Fixed by #1148
Closed
3 tasks done
Tracked by #452

Checkbox - add required prop #673

thrbnhrtmnn opened this issue Dec 5, 2023 · 2 comments · Fixed by #1148
Assignees
@ashk1996
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Dec 5, 2023 •
edited
Loading

Description / User Story

The checkbox should also have a required prop.
The indeterminatedIcon prop should be renamed to indeterminateIcon.

Acceptance Criteria

  • The checkbox has a required prop, that functions exactly like in other form components
  • The section "Required" has been added under "Validation", incl. an example of a checkbox with required=true. Use the same text as defined in the Props Excel
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here

Background information

  • ...
This was referenced Dec 5, 2023
Open
Closed
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers 📋 task::planned ⭕ core team issue This is for the core team and should not be done by contributors and removed 📋 task::planned labels Jan 3, 2024
@angelicahoyss
Copy link
Contributor

Closing as duplicate, all of these tasks are included in #800

@angelicahoyss angelicahoyss closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@thrbnhrtmnn thrbnhrtmnn reopened this Jan 17, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Checkbox - add required prop and rename indeterminatedIcon prop Checkbox - add required prop Jan 17, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Reopened this issue. The fix to add required prop should be part of this issue and the renaming will be moved to the prop alignment ticket

@angelicahoyss angelicahoyss mentioned this issue Jan 17, 2024
Closed
5 tasks
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Mar 28, 2024
@ashk1996 ashk1996 self-assigned this Aug 12, 2024
@ashk1996 ashk1996 mentioned this issue Aug 26, 2024
Merged
@thrbnhrtmnn thrbnhrtmnn linked a pull request Aug 26, 2024 that will close this issue
fix(ui-library): checkbox component fixes #1148
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashk1996 ashk1996

Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

Successfully merging a pull request may close this issue.

fix(ui-library): checkbox component fixes deven-org/boiler
3 participants
@angelicahoyss @thrbnhrtmnn @ashk1996