Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton - encourage variant does not reach contrast minimum in light theme #661

Closed
Tracked by #813
thrbnhrtmnn opened this issue Nov 29, 2023 · 1 comment
Closed
Tracked by #813

TextButton - encourage variant does not reach contrast minimum in light theme #661

thrbnhrtmnn opened this issue Nov 29, 2023 · 1 comment
Assignees
@m-nti
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers 🚨 new::bug Something isn't working

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 29, 2023 •
edited
Loading

Step-by-Step Guide to reproduce

  1. Open TextButton in Storybook
  2. (Set theme to light and background to light)
  3. Set variant to encourage
  4. Open Accessibility Add-on
  5. See contrast violation

Bug Description / False Behaviour

The TextButton in the encourage variant in light theme does not meet the contrast minimum.

Correct Behaviour

The TextButton in the encourage variant in light theme does meet the contrast minimum.

Testing

Check existing unit tests of the component(s) and adjust the tests to prevent this bug from occurring again in the future, if you see a way.

Background

  • In case props were changed: Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here
@thrbnhrtmnn thrbnhrtmnn added the 🚨 new::bug Something isn't working label Nov 29, 2023
This was referenced Nov 29, 2023
Closed
Open
@thrbnhrtmnn thrbnhrtmnn added the 🎨 design issue Task is for designers label Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Release 1.0, Beta Release Jan 9, 2024
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Jan 19, 2024
Open
13 tasks
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Beta Release, Release 1.0 Feb 8, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Issue has been solved by the token renaming

@thrbnhrtmnn thrbnhrtmnn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the v1.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-nti m-nti

Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers 🚨 new::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-nti @thrbnhrtmnn