Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton & IconButton - remove hover, pressed and focus state for loading buttons #631

Closed
Tracked by #452
thrbnhrtmnn opened this issue Nov 22, 2023 · 2 comments
Closed
Tracked by #452

TextButton & IconButton - remove hover, pressed and focus state for loading buttons #631

thrbnhrtmnn opened this issue Nov 22, 2023 · 2 comments
Assignees
@RubirajAccenture
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 22, 2023 •
edited
Loading

Step-by-Step Guide to reproduce

  1. Open TextButton/IconButton in Storybook
  2. Set the "loading" prop to true
  3. Hover/Press/Focus the button
  4. See that the visuals of the button change

Bug Description / False Behaviour

The buttons have a hover, pressed and focus state when loading is true.

Correct Behaviour

The buttons do not have a hover, pressed and focus state when loading is true. We have to also make clear for screen readers that the button is not clickable in the loading state.

We might even have to add a separate aria label for loading state, but this should be verified first. There is i.e. a area-busy attribute.

Testing

Add a test for the click-event not to fire in loading and disable state.

Background

  • In case props were changed: Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here
@thrbnhrtmnn thrbnhrtmnn added the 🚨 new::bug Something isn't working label Nov 22, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Nov 22, 2023
Open
@thrbnhrtmnn thrbnhrtmnn added 📋 task::ready Task is ready to be picked up or planned in 🎓 junior issue Good for juniors labels Nov 23, 2023
@RubirajAccenture RubirajAccenture self-assigned this Nov 24, 2023
@thrbnhrtmnn thrbnhrtmnn added 📋 task::planned ⌨️ dev issue Task is for developers and removed 📋 task::ready Task is ready to be picked up or planned in labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added ⭕ core team issue This is for the core team and should not be done by contributors and removed 📋 task::planned labels Jan 5, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Feedback: Problem is fixed, we only saw one issue now with the size of the loader icon in the textbutton being too small. This is no the case on the current develop and should be looked into before merging the changes.

@thrbnhrtmnn
Copy link
Contributor Author

After merge the issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RubirajAccenture RubirajAccenture

Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

No branches or pull requests
2 participants
@thrbnhrtmnn @RubirajAccenture