Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio - replace children with props #521

Closed
9 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Nov 1, 2023 · 1 comment
Closed
9 tasks done
Tracked by #452

Radio - replace children with props #521

thrbnhrtmnn opened this issue Nov 1, 2023 · 1 comment
Labels
⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 1, 2023

Description / User Story

Currently we have a child in the radio that includes multiple other props in an array. This should not be the case and the props should be there outside of the child instead.


Acceptance Criteria

  • The radio component does not have props inside an array anymore
  • The radio component now also has the following props:
    • label
    • value
    • checked (was already part of radio before, but also part of the array and should also be looked at)
    • hintMessage (only show when hasHint == true)
    • errorMessage (only show when hasError == true)
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here
  • In case Storybook Documentation - Component: Radio #500 is done: update component page in Storybook

Background information

  • ...
@thrbnhrtmnn
Copy link
Contributor Author

As seen within #500 , this task has already been done, probably together with #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant