Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton - adjust icon props #514

Closed
4 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Oct 30, 2023 · 2 comments
Closed
4 tasks done
Tracked by #452

TextButton - adjust icon props #514

thrbnhrtmnn opened this issue Oct 30, 2023 · 2 comments
Assignees
@DenizSaganak
Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 30, 2023 •
edited
Loading

Description / User Story

Instead of leadingIcon and trailingIcon we want to use "hasIcon", "(hasIcon) -> icon" and "(hasIcon) -> iconPosition" as props to define the icons for a textButton.

Acceptance Criteria

  • ledingIcon and trailingIcon props have been removed
  • icons inside the textButton component can be defined and adjusted with the new props "hasIcon", "(hasIcon) -> icon" and "(hasIcon) -> iconPosition"
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color
  • In case Storybook Documentation - Component: Text Button #412 is done: update component page in Storybook

Background information

  • ...
  • ...
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 30, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Oct 30, 2023
Open
@thrbnhrtmnn thrbnhrtmnn added the 🎓 junior issue Good for juniors label Nov 10, 2023
@DenizSaganak DenizSaganak self-assigned this Nov 20, 2023
@DenizSaganak
Copy link
Contributor

Dev is done. PR: #620

@DenizSaganak DenizSaganak mentioned this issue Nov 21, 2023
Merged
@thrbnhrtmnn
Copy link
Contributor Author

All ACs were checked in todays design review session.

@thrbnhrtmnn thrbnhrtmnn added the ⌨️ dev issue Task is for developers label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenizSaganak DenizSaganak

Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

No branches or pull requests
2 participants
@thrbnhrtmnn @DenizSaganak