Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconButton & TextButton - fix disabled state #499

Closed
6 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Oct 24, 2023 · 2 comments
Closed
6 tasks done
Tracked by #452

IconButton & TextButton - fix disabled state #499

thrbnhrtmnn opened this issue Oct 24, 2023 · 2 comments
Assignees
@RubirajAccenture
Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Milestone
Align & Fix First...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 24, 2023 •
edited
Loading

Description / User Story

The disabled state for IconButton and TextButton needs be correctly implemented visually, semantically and behavioural. Meaning it should look visually as defined in design, it should semantically work so that i.e. screen readers work accordingly and it needs to not be interactive (not selectable or focusable).

Acceptance Criteria

  • The disabled state in the IconButton has the defined visuals
  • The disabled state in the IconButton has the defined semantics
  • The disabled state in the IconButton has the defined behaviour
  • The disabled state in the TextButton has the defined visuals
  • The disabled state in the TextButton has the defined semantics
  • The disabled state in the TextButton has the defined behaviour

Background information

  • Found in Merge & Review session on 24.10.2023
@thrbnhrtmnn thrbnhrtmnn added the 🎓 junior issue Good for juniors label Oct 24, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 24, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Oct 24, 2023
Open
@thrbnhrtmnn
Copy link
Contributor Author

thrbnhrtmnn commented Nov 9, 2023 •
edited
Loading

From todays Merge/Review session:

  • Icon color and label color was wrong

@thrbnhrtmnn
Copy link
Contributor Author

Checked ACs again today with @RubirajAccenture and @ChristianHoffmannS2 . After the merge is done and the discussed small adjustments regarding semantics, the Ticket can be closed as done.

@thrbnhrtmnn thrbnhrtmnn added the ⌨️ dev issue Task is for developers label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RubirajAccenture RubirajAccenture

Labels
⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

No branches or pull requests
2 participants
@thrbnhrtmnn @RubirajAccenture