Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - add readonly state to code #476

Closed
6 tasks
Tracked by #452
thrbnhrtmnn opened this issue Oct 19, 2023 · 2 comments
Closed
6 tasks
Tracked by #452

Select - add readonly state to code #476

thrbnhrtmnn opened this issue Oct 19, 2023 · 2 comments
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 📋 task::ready Task is ready to be picked up or planned in

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 19, 2023

Description / User Story

Readonly state of select is currently missing in code and needs to be added.


Acceptance Criteria

  • Select has a readonly state in code, which looks exactly like in design (icons, if otherwise shown, should be not displayed in readonly state)
  • Update component documentation in Storybook
    • Move readonly to "States" in the props panel, give it a boolean control and the default "false"
    • Add "or readonly" in description of the states section after "disabled"
    • Add a sub-section titled "Readonly" incl. the texts defined in the Excel (currently marked red) and a simple example of the default Select, but with readonly=true and label="Readonly"
  • Props Excel has been updated / comments have been resolved and props changed from red to black font color

Background information

  • ...
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 19, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⌨️ dev issue Task is for developers label Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors ⭕ core team issue This is for the core team and should not be done by contributors labels Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Align & Fix First 15 Components, Evaluate Validation in React Feb 12, 2024
@kathikraemer kathikraemer self-assigned this Feb 14, 2024
@thrbnhrtmnn
Copy link
Contributor Author

As discussed yesterday with @larserbach, @ChristianHoffmannS2 and @kathikraemer , the readonly state for the select is still something we want to provide, even though this is not part of the standard html select. We already had a somewhat working version with little effort.

As Kathis is no longer on the project, we can pick this up at a later point again.

@thrbnhrtmnn
Copy link
Contributor Author

We decided to remove the readonly state in design, this task is not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Development

No branches or pull requests

2 participants